[v24.2.x] c/controller_backend: allow shutdown_partition to fail on app shutdown
#24372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `ss::gate_closed_exception` only. This is to untangle a race condition between partition shutdown and app shutdown. Callers should consider the operation unsuccessful and will probably retry it, as `shard_placement_table` is not going to be updated. While this unsuccessful operation will leave the partition in a somewhat orphaned state, i.e. without appropriate `shard_table` entries, the rest of the system should be able to live with it in the same way as it lives during a successful partition shutdown. (cherry picked from commit 0bb1be6)
bashtanov
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #24358