uv adapter: reduce number of uv_poll_start calls #908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally uv_poll_start iterates over all attached event handlers to update event mask. It's quite expensive operation if there many event handlers attached to a loop. As redisLibuvEvents.events is a copy of what libuv should see, we can rely on it to avoid event mask updates. Signed-off-by: Anton Tiurin <noxiouz@yandex.ru>
|
Hi @noxiouz sorry for the delay getting to this but I've been busy on another project. I'll try to get this tested/merged this weekend. |
|
Closing in favor of rebased #1098 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally uv_poll_start iterates over all attached event handlers to update event mask.
It's quite expensive operation if there many event handlers attached
to a loop
As redisLibuvEvents.events is a copy of what libuv should see,
we can rely on it to avoid event mask updates.
For example, in async.c#L662 there is a high chance that fd is already being listened for writable events
Signed-off-by: Anton Tiurin noxiouz@yandex.ru