-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(RHEL-55708) rhel 9 fix 55708 #99
Conversation
pvalena
commented
Nov 27, 2024
•
edited by github-actions
bot
Loading
edited by github-actions
bot
- fix(kernel-modules): use modalias info in get_dev_module()
- fix(dracut-functions.sh): convert mmcblk to the real kernel module name
When calling dracut with '--hostonly-mode=strict', get_dev_module() gets called on the system's block devices to find the required drivers. The driver name is retrieved using udevadm. However, the driver name returned by udevadm is not necessarily the same as the module name. This is the case for the Qualcomm UFS driver: udevadm returns 'ufshcd-qcom' while the module name is 'ufs-qcom', so dracut-install is not able to find the module afterwards. To solve this, make get_dev_module() also return the module alias info from the modalias files contained in the sysfs directories parsed by udevadm. Signed-off-by: Adrien Thierry <athierry@redhat.com> (cherry picked from commit 87a76db) Resolves: RHEL-55708
In some x86_64 platforms such as Intel Elkhartlake, an issue of missing necessary modules due to udevadm drivers field unmatch the real kernel module name is found: $ udevadm info -a /dev/block/179:1 looking at parent device '/devices/pci0000:00/0000:00:1a.0/mmc_host/mmc0/mmc0:0001': KERNELS=="mmc0:0001" SUBSYSTEMS=="mmc" DRIVERS=="mmcblk" .... The DRIVERS field, aka mmcblk will be given to instmods to install the corresponding mmc_block.ko kernel module. However mmc_block.ko cannot be selected by string mmcblk, as a result, mmc_block.ko cannot be installed in hostonly-mode strict, which will fail to bootup the machine such as in kdump cases: $ /usr/lib/dracut/dracut-install -D /var/tmp --kerneldir /lib/modules/$(uname -r)/ -m mmcblk dracut-install: Failed to find module 'mmcblk' In this patch, we will convert the string mmcblk to mmc_block, so the kernel module can be successfully loaded. Signed-off-by: Tao Liu <ltao@redhat.com> (cherry picked from commit a62e895) Resolves: RHEL-55708
Commit validationTracker - RHEL-55708 The following commits meet all requirements
Tracker validationFailed🔴 Tracker RHEL-55708 is missing severity Success🟢 Tracker RHEL-55708 has set desired product: Pull Request validationFailed🔴 Failed or pending checks - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.