Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(RHEL-64754) fix(35network-manager): install nft binary during module installation #97

Merged
merged 2 commits into from
Nov 27, 2024
Merged

(RHEL-64754) fix(35network-manager): install nft binary during module installation #97

merged 2 commits into from
Nov 27, 2024

Conversation

pvalena
Copy link
Contributor

@pvalena pvalena commented Nov 27, 2024 •
edited
Loading

  • fix(35network-manager): install nftables kernel modules needed
  • fix(35network-manager): install nft binary during module installation
    Resolves: RHEL-64754

@pvalena pvalena added the bug Something isn't working label Nov 27, 2024
@pvalena pvalena self-assigned this Nov 27, 2024
@ffmancera @pvalena
fix(35network-manager): install nftables kernel modules needed
bf50599 
NetworkManager requires nf_tables, nfnetlink and nft_fwd_netdev kernel
modules to operate balance-slb bonding mode.

Fixes a6264d1726d9 ("fix(35network-manager): install nft binary during module installation")

(cherry picked from commit 037da383dd8d9d9d699f1430d6afc790b28b18f8)

Resolves: RHEL-64754
@github-actions github-actions bot changed the title fix(35network-manager): install nft binary during module installation (RHEL-64754) fix(35network-manager): install nft binary during module installation Nov 27, 2024
@github-actions GitHub Actions
Copy link

Commit validation

Tracker - RHEL-64754

The following commits need an inspection

commit note
f70b1d7 - fix(35network-manager): install nft binary during module installation Missing upstream reference ‼️

Pull Request validation

Failed

🔴 Failed or pending checks - test (centos:stream9, 36)[failure],test (centos:stream9, 35)[failure],test (centos:stream9, 31)[failure],test (centos:stream9, 30)[failure],test (centos:stream9, 15)[failure],test (centos:stream9, 14)[failure],test (centos:stream9, 03)[failure],centos-9-stream (centos:stream9, 98)[cancelled],centos-9-stream (centos:stream9, 41)[cancelled],centos-9-stream (centos:stream9, 40)[cancelled],centos-9-stream (centos:stream9, 21)[cancelled],centos-9-stream (centos:stream9, 20)[cancelled],centos-9-stream (centos:stream9, 17)[cancelled],centos-9-stream (centos:stream9, 16)[cancelled],centos-9-stream (centos:stream9, 12)[cancelled],centos-9-stream (centos:stream9, 13)[cancelled],centos-9-stream (centos:stream9, 11)[cancelled],centos-9-stream (centos:stream9, 10)[cancelled],centos-9-stream (centos:stream9, 02)[cancelled],centos-9-stream (centos:stream9, 01)[cancelled],basic (centos:stream9, 04)[failure],testing-farm:centos-stream-9-x86_64[in_progress],rpm-build:centos-stream-9-x86_64[in_progress],rpm-build:centos-stream-9-aarch64[in_progress],test (centos:stream9, 98)[in_progress],test (centos:stream9, 21)[in_progress],test (centos:stream9, 20)[in_progress],test (centos:stream9, 17)[in_progress],test (centos:stream9, 16)[in_progress],test (centos:stream9, 13)[in_progress],test (centos:stream9, 12)[in_progress],test (centos:stream9, 10)[in_progress],test (centos:stream9, 01)[in_progress],lint-shell[in_progress]
🔴 Review - Missing review from a member (1 required)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Commit validation

Tracker - RHEL-64754

The following commits need an inspection

commit note
bf50599 - fix(35network-manager): install nftables kernel modules needed Missing upstream reference ‼️
48ff571 - fix(35network-manager): install nft binary during module installation Missing upstream reference ‼️

Tracker validation

Success

🟢 Tracker RHEL-64754 has set desired product: rhel-9.2.0.z
🟢 Tracker RHEL-64754 has set desired component: dracut
🟢 Tracker RHEL-64754 has been approved
🟢 Tracker RHEL-64754 has set severity

Pull Request validation

Failed

🔴 Failed or pending checks - testing-farm:centos-stream-9-x86_64[failure],test (centos:stream9, 36)[failure],test (centos:stream9, 35)[failure],test (centos:stream9, 31)[failure],test (centos:stream9, 30)[failure],test (centos:stream9, 15)[failure],test (centos:stream9, 14)[failure],test (centos:stream9, 03)[failure],centos-9-stream (centos:stream9, 98)[cancelled],centos-9-stream (centos:stream9, 21)[cancelled],centos-9-stream (centos:stream9, 41)[cancelled],centos-9-stream (centos:stream9, 40)[cancelled],centos-9-stream (centos:stream9, 20)[cancelled],centos-9-stream (centos:stream9, 17)[cancelled],centos-9-stream (centos:stream9, 16)[cancelled],centos-9-stream (centos:stream9, 12)[cancelled],centos-9-stream (centos:stream9, 13)[cancelled],centos-9-stream (centos:stream9, 11)[cancelled],centos-9-stream (centos:stream9, 10)[cancelled],centos-9-stream (centos:stream9, 02)[cancelled],centos-9-stream (centos:stream9, 01)[cancelled],basic (centos:stream9, 04)[failure]
🔴 Review - Missing review from a member (1 required)

@ffmancera @pvalena
fix(35network-manager): install nft binary during module installation
48ff571 
NetworkManager has a new bonding mode called balance-slb. This mode is
used in environments where NICs are connected to switches without LACP.
In order to work, NetworkManager configures a set of nftables rules.

The 'nft' binary is required to work.

Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>

(cherry picked from commit 37317b61fda5181aeb0604381e994e8181a53200)

Resolves: RHEL-64754
@pvalena
Copy link
Contributor Author

pvalena commented Nov 27, 2024

LGTM.

@pvalena pvalena merged commit 3db62d5 into redhat-plumbers:main Nov 27, 2024
23 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pvalena pvalena

Labels
bug Something isn't working modules network-manager pr/needs-ci pr/needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvalena @ffmancera