Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

League event: change dispatch string events to objects #6029

Merged
merged 9 commits into from
Apr 9, 2021
Merged

League event: change dispatch string events to objects #6029

merged 9 commits into from
Apr 9, 2021

Conversation

lulco
Copy link
Contributor

@lulco lulco commented Apr 2, 2021 •
edited
Loading

Updated league event upgrade:

  • changed AddInterfaceByParentRector
  • added DispatchStringToObjectRector

@lulco lulco changed the title WIP: League event: change dispatch string events to objects League event: change dispatch string events to objects Apr 2, 2021
@lulco
Copy link
Contributor Author

lulco commented Apr 3, 2021 •
edited
Loading

Errors don't seem to be related to this PR

@samsonasik
Copy link
Member

@lulco please rebase

@lulco
Copy link
Contributor Author

lulco commented Apr 4, 2021

@lulco please rebase

Sorry, I am not near computer. Maybe at night

@lulco
Copy link
Contributor Author

lulco commented Apr 4, 2021

@samsonasik I've merge master into my branch, but the build is broken again because of this commit 393031b

@lulco
Copy link
Contributor Author

lulco commented Apr 4, 2021

@samsonasik @TomasVotruba build is finally green, ready for review and merge O:-)

@TomasVotruba
Copy link
Member

Thank you for the PR 👍 I've added few comments

@TomasVotruba
Copy link
Member

Let's add this as it is, LGTM 👍

@TomasVotruba TomasVotruba merged commit 4b71eaa into rectorphp:main Apr 9, 2021
@TomasVotruba TomasVotruba mentioned this pull request Apr 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomasVotruba TomasVotruba TomasVotruba left review comments

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lulco @samsonasik @TomasVotruba