[CI] Drop fixture checks, that are now covered by static reflection #5831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
TomasVotruba
changed the title
TomasVotruba
force-pushed
the
fixture-naming-drop-2
branch
from
832d230 to
82fec5a
Compare
TomasVotruba
commented
Mar 13, 2021
| @@ -36,7 +36,7 @@ use PhpParser\Node; | |||
| use PhpParser\Node\Expr\Array_; | |||
| use PhpParser\Node\Stmt\Nop; | |||
|
|
|||
| final class ImproveNullable | |||
| final class DoubleCallArray | |||
There was a problem hiding this comment.
This class is now duplicated, but tests still work
|
@TomasVotruba Thank you 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Apr 19, 2024
rectorphp/rector-src@5e213e6 Revert "Faster FileInfoMatcher (#5830)" (#5831)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #5665, each fixture file is parsed as unique per-test file content.
Before we needed unique fixture, to avoid autoloading crashes. Now the static reflection removes this problem.
It was useful in time before though 👍 cc @samsonasik