Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeDeclaration] Skip nullable self referencing param and return on AddArrayParamDocTypeRector and ReturnTypeDeclarationRector #1183

Merged
merged 6 commits into from
Nov 8, 2021
Merged

[TypeDeclaration] Skip nullable self referencing param and return on AddArrayParamDocTypeRector and ReturnTypeDeclarationRector #1183

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f23fcb1
Adding tests based on examples
liarco Nov 7, 2021
595f31d
handle MixedType
samsonasik Nov 8, 2021
bdf08c3
phpstan
samsonasik Nov 8, 2021
7960b00
fix subtype in union
TomasVotruba Nov 8, 2021
0b2ceb4
fix FuncCall node name
TomasVotruba Nov 8, 2021
78b0f6e
fix serliaze on MixedType hashing
TomasVotruba Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/NodeTypeResolver/PHPStan/TypeHasher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public function areTypesEqual(Type $firstType, Type $secondType): bool
public function createTypeHash(Type $type): string
{
if ($type instanceof MixedType) {
return serialize($type) . $type->isExplicitMixed();
return $type->describe(VerbosityLevel::precise()) . $type->isExplicitMixed();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some wierd cases, the MixedType contains closures that cannot be serialized.

}

if ($type instanceof ArrayType) {
Expand Down