Move WithConsecutiveRector to its PHPUnit100 namespace, CreateMockToAnonymousClassRector + PreferPHPUnitSelfCallRector to CodeQuality #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
changed the title
…om incorrect /src path to /rules
TomasVotruba
force-pushed
the
tv-fix-location
branch
from
66fcc47 to
3659dfb
Compare
|
Risk of BC break is present, but these are part of sets, or used as onesies - run once and then removed. So we should be fine :) |
|
Ran into this as a breaking change. But was only a 5 minutes inconvenience until I figured it out. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just noticed this when the rule could not be found:
https://getrector.com/find-rule?query=withConsecutive
It was in wrong location, should be always in
/rules. This PR fixes them to Rector-extension standard and fixes the find-rule page consequently (pun intended :))