RCORE-2108 Avoid deleting self if the instance of the same object is added to a collection in a mixed. #7647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicola-cab
commented
Apr 29, 2024
| for (auto& obj : objs) | ||
| CHECK(obj.get_backlink_count() == 1); | ||
|
|
||
| for (auto& obj : objs) |
There was a problem hiding this comment.
this fails:
Assertion failed: begin <= end [2, 1]
0 realm-tests 0x000000010bd8d159
…ollection created from the same table and colkey
nicola-cab
changed the title
Pull Request Test Coverage Report for Build nicola.cabiddu_1676Details
💛 - Coveralls |
nicola-cab
changed the title
jedelbo
requested changes
May 7, 2024
| // Update size (also in header) | ||
| --m_size; | ||
| set_header_size(m_size); | ||
| if (ndx < size()) { |
There was a problem hiding this comment.
I would say it is an error in the calling code if ndx is not smaller than size.
| @@ -969,6 +969,40 @@ TEST(List_NestedCollection_Unresolved) | |||
| CHECK_EQUAL(list.get(0), Mixed(obj.get_link())); | |||
| } | |||
|
|
|||
| TEST(Collection_Mixed_avoid_deleting_self) | |||
There was a problem hiding this comment.
The code above is not called when this test is run.
| for (auto& obj : objs) | ||
| CHECK(obj.get_backlink_count() == 1); | ||
|
|
||
| for (auto& obj : objs) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
We should not allow this behaviour, probably the right fix is to throw an exception if we add a link to an object that is basically an instance of the same table, if the table has just one mixed column.
The aim is to prevent this issue: #7657
☑️ ToDos
bindgen/spec.yml, if public C++ API changed