-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: update reproducible builds guide #10939
Docs: update reproducible builds guide #10939
Conversation
I finished the main proposed modifications. However, I don't understand the "✅ Good:" badge in Pin your transitive dependencies. Any thoughts ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I think it's good and ready to merge after some small changes 👍🏼
0d3b71b
to
0ca4e6b
Compare
Sorry for the delay. I commented on the various points you raised and modified the code. |
Any news ? |
Still no news ? |
This PR has conflicts -- I think because we addressed the change with the YAML file being required already. So it's probably fine to update this to just include the warning, and I'm fine to merge it. |
@duboism You may want to fix the conflicts and address the comment above. |
@htech9, sorry I was busy on other duties. I will adress that quickly. |
As requested, I updated the branch to just include the warning (and an obvious typo). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks :)
Thanks for merging. The world is a little better now :) |
As discussed in #10924, we propose to update the reproducible builds guide (
docs/user/guides/reproducible-builds.rst
). The goals are:sphinx=5.3.0
in the example📚 Documentation previews 📚
docs
): https://docs--10939.org.readthedocs.build/en/10939/dev
): https://dev--10939.org.readthedocs.build/en/10939/