Automation Rules: simplify ordering #10896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to re-use this for redirects, and found a couple of things that we can improve.
New items would be inserted first instead of at the end, if a user is adding a new item, they may want to have it priority over existing ones. Inserting the item at the end was mostly done because it was "easier" to implement.
Instead of explicitly using the manager to add a new rule, just override the save() method. This allows us to:
With this, we no longer need to override forms, serializers, etc, saving the model will take care of putting the rule in the right place.
📚 Documentation previews 📚
docs
): https://docs--10896.org.readthedocs.build/en/10896/dev
): https://dev--10896.org.readthedocs.build/en/10896/