Remove klipper-lb #7012
Closed
Remove klipper-lb #7012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: manuelbuil <mbuil@suse.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7012 +/- ##
=======================================
Coverage 25.11% 25.11%
=======================================
Files 33 33
Lines 2839 2839
=======================================
Hits 713 713
Misses 2079 2079
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Oct 11, 2024
brandond
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Cannot do this until we have a build of /~https://github.com/rancher/image-build-rke2-cloud-provider that includes the changes from K3s. That repo currently only allows building against tagged releases of K3s, there is no way to build against the head of the current release branch - so we'll need to wait until after we have a release of K3s that includes these changes, to use them in RKE2.
|
Handling this in #7031 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Following on from k3s changes: k3s-io/k3s#10954, replace klipper-lb with busybox image.
THIS REQUIRES USING NEW K3S
Types of Changes
New feature
Verification
Deploy RKE2 and deploy a type:LoadBalancer service
Testing
Linked Issues
#7013
User-Facing Change
Further Comments