make the index a table again #457
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+26
to
+33
| <tr class="border-b"> | ||
| <% attributes.reject(&:password_digest?).each do |attribute| -%> | ||
| <td class="py-4 whitespace-nowrap"><%%= <%= singular_name %>.<%= attribute.column_name %> %></td> | ||
| <% end -%> | ||
| <td class="py-4 space-x-4 whitespace-nowrap"> | ||
| <%%= link_to "Show", <%= model_resource_name(singular_table_name) %>, class: "text-blue-600 hover:text-blue-900" %> | ||
| </td> | ||
| </tr> |
There was a problem hiding this comment.
we can still have this in a partial but i don't see the benefit - i don't think it'll be used somewhere else.
| <td class="py-4 whitespace-nowrap"><%%= <%= singular_name %>.<%= attribute.column_name %> %></td> | ||
| <% end -%> | ||
| <td class="py-4 space-x-4 whitespace-nowrap"> | ||
| <%%= link_to "Show", <%= model_resource_name(singular_table_name) %>, class: "text-blue-600 hover:text-blue-900" %> |
There was a problem hiding this comment.
I kept just the link to the show action, but we can also add the Edit and Destroy links. thoughts?
patriciomacadden
force-pushed
the
index-table
branch
from
c881254 to
91e8705
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this PR, the scaffold generator stopped generating a table in the index page, and encourages css frameworks gems (such as this) to do the styling.
I don't quite like what the generator generates currently (design wise, although I'm no designer), so I thought of bringing back the table, with a basic style so it's ready to use (or as ready to use as possible).
I looked for box-style CRUD designs so we could keep using the partial but I couldn't find anything.
As always, before and after pictures: