-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rad resource expose containers
and rad resource logs
commands
#8710
Conversation
Radius functional test overview
Click here to see the list of tools in the current test run
Test Status⌛ Building Radius and pushing container images for functional tests... |
@@ -33,7 +33,7 @@ import ( | |||
const ( | |||
LevenshteinCutoff = 2 | |||
|
|||
ContainerType = "Applications.Core/containers" | |||
ContainerType = "containers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this exported? Is it being used anywhere else?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8710 +/- ##
=======================================
Coverage 59.88% 59.88%
=======================================
Files 596 596
Lines 40512 40512
=======================================
Hits 24261 24261
Misses 14423 14423
Partials 1828 1828 ☔ View full report in Codecov by Sentry. |
Closing because this is intentional behavior, not a bug. We should update the docs and samples instead. |
Description
Fix regression which caused
rad resource expose
andrad resource logs
to fail.Type of change
Fixes: #8709
Contributor checklist
Please verify that the PR meets the following requirements, where applicable: