-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 6.5.2 #38
Update to 6.5.2 #38
Conversation
Thanks, @bethanyhgardner, this looks great. A few questions:
|
Hi, Ahh, sorry for my delayed response! I just submitted the contributor agreement. I downloaded the free web version of fontawesome 6.5.2 and cross-referenced the files there with the ones included in this extension (the .ttf and .woff2 files in |
Would be lovely to have this merged! Thanks @bethanyhgardner for the PR! |
What's holding this PR up? It would be great to have fontawesome updated to the latest version. (I know I can just install the version from @bethanyhgardner.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay on this one.
I downloaded the free web version of fontawesome 6.5.2 and cross-referenced the files there with the ones included in this extension (the .ttf and .woff2 files in webfonts/ and all.css in css/).
I think this is the right way to do it. The change we see is because the previous update 6.4.2 was not exactly using the all.css for the 6.4.2 free download of fontawesome release.
This PR makes things cleaner for future update regarding this extension providing equivalent of Free release of fontawesome at /~https://github.com/FortAwesome/Font-Awesome/releases
the other files that we're still shipping, but haven't changed.
I think we need to remove those.
I needed the Upwork and Bluesky icons that were added in v6.5, so I modified the asset files in my project's installation of the extension, modeling it after the changes in #32. Here it is, in case anyone else needs it! It works for my website, adding both new icons and icons that have existed in previous versions, but I'm not sure if there's a conventional way to test the full set of icons and the various ways to insert them.