Merge pull request #45567 from rsvoboda/java11.comments

AppcdsConfig and ProcessHandle comments adjustments
quarkusio · Jan 14, 2025 · 2708ac8 · 2708ac8
2 parents 9efb549 + 5780131
commit 2708ac8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/core/deployment/src/main/java/io/quarkus/deployment/ide/IdeProcessor.java b/core/deployment/src/main/java/io/quarkus/deployment/ide/IdeProcessor.java
@@ -189,7 +189,6 @@ public IdeRunningProcessBuildItem detectRunningIdeProcesses(LaunchModeBuildItem
         return new IdeRunningProcessBuildItem(result);
     }
 
-    // TODO: remove when we move to Java 11 and just call the methods of 'java.lang.ProcessHandle'
     private static class ProcessUtil {
 
         /**

diff --git a/core/deployment/src/main/java/io/quarkus/deployment/pkg/PackageConfig.java b/core/deployment/src/main/java/io/quarkus/deployment/pkg/PackageConfig.java
@@ -165,8 +165,7 @@ interface JarConfig {
         interface AppcdsConfig {
             /**
              * Whether to automate the creation of AppCDS.
-             * Furthermore, this option only works for Java 11+ and is considered experimental for the time being.
-             * Finally, care must be taken to use the same exact JVM version when building and running the application.
+             * Care must be taken to use the same exact JVM version when building and running the application.
              */
             @WithDefault("false")
             boolean enabled();
-Original file line number
+Diff line change
@@ Expand Up @@
             return new IdeRunningProcessBuildItem(result);
         }
-        // TODO: remove when we move to Java 11 and just call the methods of 'java.lang.ProcessHandle'
         private static class ProcessUtil {
             /**
@@ Expand Down @@