Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update AW20216S driver and configuration for GMMK/Pro keyboard #13173
Update AW20216S driver and configuration for GMMK/Pro keyboard #13173
Changes from 4 commits
d312c6d
887c362
e05b5d9
0d06451
3d5de68
11522a0
b71ea57
a2c0b44
4b05c6f
39b481e
8dce49b
0f1b16e
311bc8a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this wait even do?
Why would driving the CS pin cause a POR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like the comment says; this delay waits for POR to complete. More specifically it waits for Over Temperature Protection to finish loading after POR. Without it, Over Temperature Protection doesn't work and you risk frying your AW20216S. This needs to happen before anything else. OTP is on by default. I think this is the only required delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow, asserting the CS pin has nothing to do with POR.
If the intention is to guarantee that this wait happens after POR, the chip should be reset first.
As it is, the time it takes for QMK to boot up and even reach this code is almost certainly long enough to not bother with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function AW20216S_enable() contains the delays that you can find in the Power up Timing figure in the DS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's... not what this code does.
EDIT: If we're suddenly going to refer to the datasheet, care to actually release it?