Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower node version since 10 is not needed #164

Merged
merged 3 commits into from
Mar 8, 2019
Merged

Lower node version since 10 is not needed #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c478ba
Update package.json
yoohahn Mar 8, 2019
e220fab
Update config.yml
yoohahn Mar 8, 2019
264d769
Update package.json
yoohahn Mar 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:
NVM_DIR="/opt/circleci/.nvm"
curl -ogit https://raw.githubusercontent.com/creationix/nvm/v0.33.6n/install.sh | bash
[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"
echo "Installing Node 10.11.0"
nvm install 10.11.0
nvm alias default 10.11.0
echo "Installing Node 8"
nvm install 8
nvm alias default 8
# Each step uses the same `$BASH_ENV`, so need to modify it
echo 'export NVM_DIR="/opt/circleci/.nvm"' >> $BASH_ENV
echo "[ -s \"$NVM_DIR/nvm.sh\" ] && . \"$NVM_DIR/nvm.sh\"" >> $BASH_ENV
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
],
"main": "dist/leonardo-ui.min.js",
"engines": {
"node": ">=10.11.0"
"node": ">=8"
},
"scripts": {
"build": "webpack --config ./tools/webpack.config.js",
Expand Down