Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scene function to use Hvplot backend visualization #2106

Merged
merged 42 commits into from
Dec 15, 2023

Holoviews inside to_hvplot method

9b0bcae
Select commit
Loading
Failed to load commit list.
Merged

Add Scene function to use Hvplot backend visualization #2106

Holoviews inside to_hvplot method
9b0bcae
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Dec 15, 2023 in 1m 7s

CodeScene PR Check

Code Health Quality Gates: OK

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 0 findings(s) ✅
  • Affected Hotspots: 1 files(s) 🔥

Recommended Review Level: Lightweight sanity check
View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication test_conversions.py

Annotations

Check notice on line 1 in satpy/scene.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Lines of Code in a Single File

The lines of code increases from 1287 to 1343, improve code health by reducing it to 600. The number of Lines of Code in a single file. More Lines of Code lowers the code health.

Check notice on line 1 in satpy/scene.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Number of Functions in a Single Module

The number of functions increases from 80 to 81, threshold = 75. This file contains too many functions. Beyond a certain threshold, more functions lower the code health.

Check warning on line 96 in satpy/tests/scene_tests/test_conversions.py

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Code Duplication

The module contains 4 functions with similar structure: TestSceneConversions.test_geoviews_basic_with_area,TestSceneConversions.test_geoviews_basic_with_swath,TestSceneConversions.test_hvplot_basic_with_area,TestSceneConversions.test_hvplot_basic_with_swath. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.