[dtensor][fix] fix _scaled_dot_product_flash_attention sharding #148125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/148125
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5a8391c with merge base 2978771 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/inductor
oncall: distributed
XilunWu
added a commit
that referenced
this pull request
Feb 27, 2025
ghstack-source-id: 47c426b771a7515a3057e4b1d100dac640933265 Pull Request resolved: #148125
cc H-Huang awgu kwen2501 wanchaol fegin fduwjj wz337 wconstab d4l3k c-p-i-o [ghstack-poisoned]
XilunWu
added a commit
that referenced
this pull request
Feb 28, 2025
ghstack-source-id: 408ec85127af2c09bde0248956fb6bc2456e858b Pull Request resolved: #148125
XilunWu
added
better-engineering
XilunWu
changed the title
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Feb 28, 2025
fegin
pushed a commit
to pytorch/torchtitan
that referenced
this pull request
Mar 3, 2025
…as been fixed (#912) Stack from [ghstack](/~https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #912 ### Summary This PR undo #898 and re-enables CP tests in CI as pytorch/pytorch#148125 fixed the DTensor sdp flash attention op. ### Test CI
fegin
added a commit
to pytorch/torchtitan
that referenced
this pull request
Mar 3, 2025
#921) …as been fixed (#912) Stack from [ghstack](/~https://github.com/ezyang/ghstack) (oldest at bottom): * __->__ #912 ### Summary This PR undo #898 and re-enables CP tests in CI as pytorch/pytorch#148125 fixed the DTensor sdp flash attention op. ### Test CI Co-authored-by: Xilun Wu <12968408+XilunWu@users.noreply.github.com>
majing921201
pushed a commit
to majing921201/pytorch
that referenced
this pull request
Mar 4, 2025
…rch#148125) ### Summary pytorch#146372 changed the op signature of `_scaled_dot_product_flash_attention` and as a consequence DTensor needs to change its sharding defined at /~https://github.com/pytorch/pytorch/blob/40ad5e01dff05c7d64e070fb01683820e678f788/torch/distributed/tensor/_ops/_matrix_ops.py#L232 ### Test `pytest test/distributed/tensor/test_attention.py` ### Follow-up It's still unclear why the CP unit tests were not run over the original PR which is BC-breaking. Pull Request resolved: pytorch#148125 Approved by: /~https://github.com/tianyu-l, /~https://github.com/fegin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary
#146372 changed the op signature of
_scaled_dot_product_flash_attentionand as a consequence DTensor needs to change its sharding defined atpytorch/torch/distributed/tensor/_ops/_matrix_ops.py
Line 232 in 40ad5e0
Test
pytest test/distributed/tensor/test_attention.pyFollow-up
It's still unclear why the CP unit tests were not run over the original PR which is BC-breaking.
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @tianyu-l