Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-98831: Auto-generate PREDICTED() macro calls #99102

Merged
merged 2 commits into from
Nov 4, 2022
Merged

GH-98831: Auto-generate PREDICTED() macro calls #99102

merged 2 commits into from
Nov 4, 2022

Conversation

gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Nov 4, 2022 •
edited by bedevere-bot
Loading

This allows us to remove all PREDICTED() calls from bytecodes.c. The generated_cases.c.h file is unchanged.

@gvanrossum
Auto-generate PREDICTED() macro calls
47d77ac 
This allows us to remove all PREDICTED() calls from bytecodes.c.
The generated_cases.c.h file is unchanged.
@bedevere-bot bedevere-bot mentioned this pull request Nov 4, 2022
Closed
@gvanrossum gvanrossum mentioned this pull request Nov 4, 2022
Merged
brandtbucher
brandtbucher approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

This is exactly the sort of clean improvement I was hoping we could get out of this project... excited for more.

Tools/cases_generator/generate_cases.py Outdated Show resolved Hide resolved
@gvanrossum @brandtbucher
use non capturing group
15b78f0 
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
@gvanrossum gvanrossum merged commit c885623 into python:main Nov 4, 2022
@gvanrossum gvanrossum deleted the rm-predicted branch November 4, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gvanrossum @brandtbucher @bedevere-bot