-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45209: fix UserWarning: resource_tracker
in test_multiprocessing
#28377
Conversation
cc @pitrou |
UserWarning: resource_tracker
in `test_multiproc…UserWarning: resource_tracker
in test_multiprocessing
Misc/NEWS.d/next/Tests/2021-09-15-23-32-39.bpo-45209.55ntL5.rst
Outdated
Show resolved
Hide resolved
All PRs right now have this problem: https://dev.azure.com/Python/cpython/_build/results?buildId=87889&view=logs&j=91c152bd-7320-5194-b252-1404e56e2478&t=c7e99cd8-4756-5292-d34b-246ff5fc615f Another examples: |
Windows build error on Azure Pipelines is tracked by: https://bugs.python.org/issue45220 |
8ebb6f6
to
95b5858
Compare
Rebased, CI now passes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @pitrou: Would you mind to double check this multiprocessing test fix?
I'm kind of unhappy that you have to prepend "/". SharedMemory._prepend_leading_slash does a magic dance (add/remove "/" prefix) with SharedMemory(name) constructor parameter and in SharedMemory.name property. But I don't think that it's worth it to add something just for this very specific test. We can always revisit the code later if we start to have issue on some corner cases.
Yes, me too. I've tried several other things like |
Since the slash hack is tests-only, let's have it. We can fix the fix later if we find a way to do so. |
pythonGH-28377) (cherry picked from commit f604cf1) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
GH-28499 is a backport of this pull request to the 3.10 branch. |
GH-28500 is a backport of this pull request to the 3.9 branch. |
pythonGH-28377) (cherry picked from commit f604cf1) Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
https://bugs.python.org/issue45209