Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-89640: Restore configure error message on failure to detect float word order #126569

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Nov 8, 2024

Before #126387, if we didn't detect float word order we'd raise the following configure error:

Unknown float word ordering. You need to manually preset
ax_cv_c_float_words_bigendian=no (or yes) according to your system.

This puts it back (except for host_cpu arm or wasm).

cc @erlend-aasland

…float word order

Before python#126387, if we didn't detect float word order we'd raise the following
configure error:
```
Unknown float word ordering. You need to manually preset
ax_cv_c_float_words_bigendian=no (or yes) according to your system.
```
This puts it back (except for host_cpu arm or wasm).
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (I'll make some style adjustments before landing)

@erlend-aasland erlend-aasland enabled auto-merge (squash) November 8, 2024 11:33
@erlend-aasland erlend-aasland merged commit 403410f into python:main Nov 8, 2024
37 checks passed
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
…float word order (python#126569)

Before python#126387, if we didn't detect float word order we'd raise the following
configure error:

    Unknown float word ordering. You need to manually preset
    ax_cv_c_float_words_bigendian=no (or yes) according to your system.

This puts it back (except for ARM or WASM, which as hardcoded).
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
…float word order (python#126569)

Before python#126387, if we didn't detect float word order we'd raise the following
configure error:

    Unknown float word ordering. You need to manually preset
    ax_cv_c_float_words_bigendian=no (or yes) according to your system.

This puts it back (except for ARM or WASM, which as hardcoded).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configure script cannot detect float word ordering on linux
2 participants