Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117482: Make the Slot Wrapper Inheritance Tests Much More Thorough #122867

Merged
merged 16 commits into from
Aug 12, 2024
Merged

gh-117482: Make the Slot Wrapper Inheritance Tests Much More Thorough #122867

merged 16 commits into from
Aug 12, 2024

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Aug 9, 2024 •
edited by bedevere-app bot
Loading

There were a still a number of gaps in the tests, including not looking at all the builtin types and not checking wrappers in subinterpreters that weren't in the main interpreter. This fixes all that.

I considered incorporating the names of the PyTypeObject fields (a la gh-122866), but figured doing so doesn't add much value.

@ericsnowcurrently
Keep track of the mapping between tp slots and dunder methods.
cdea026
@ericsnowcurrently
get_type_slot_wrapper_names() -> identify_type_slots().
c2a7878
@ericsnowcurrently
Fix iter_builtin_types().
c51e2a8
@ericsnowcurrently
Refactor test_static_types_inherited_slots().
4007697
@ericsnowcurrently
Temporarily hide failing corner cases.
98044a5
@ericsnowcurrently
Add a thorough search to test.support.iter_builtin_types().
0f71f95
@ericsnowcurrently
Add _PyStaticType_GetBuiltins() and _testinternalcapi.get_static_buil…
bfd2977 
…tin_types().
@ericsnowcurrently
Use the new C-API in test.support.iter_builtin_types().
ed318c2
@ericsnowcurrently
Clean up usage of _testinternalcapi.
2e3a3b8
@ericsnowcurrently
Add test.support.identify_type_slots().
9bf965a
@ericsnowcurrently
Add test.support.find_name_in_mro().
86ba359
@ericsnowcurrently
Use identify_type_slots() and find_name_in_mro() in iter_slot_wrapper…
2ebebd3 
…s().
@ericsnowcurrently
Add test.support.identify_type_slot_wrappers().
9af3eba
@ericsnowcurrently
Don't worry about preserving the slot names.
0e0e6fd
@bedevere-app bedevere-app bot mentioned this pull request Aug 9, 2024
Open
@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) August 12, 2024 19:11
@ericsnowcurrently ericsnowcurrently merged commit 503af8f into python:main Aug 12, 2024
35 checks passed
@ericsnowcurrently ericsnowcurrently deleted the fix-slot-wrapper-inheritance-tests branch August 12, 2024 19:19
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@ericsnowcurrently @blhsing
pythongh-117482: Make the Slot Wrapper Inheritance Tests Much More Th…
c10a778 
…orough (pythongh-122867)

There were a still a number of gaps in the tests, including not looking
at all the builtin types and not checking wrappers in subinterpreters
that weren't in the main interpreter. This fixes all that.

I considered incorporating the names of the PyTypeObject fields
(a la pythongh-122866), but figured doing so doesn't add much value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ericsnowcurrently