Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94673: Fix compiler warning in typeobject.c #117980

Merged
merged 2 commits into from
Apr 17, 2024
Merged

gh-94673: Fix compiler warning in typeobject.c #117980

merged 2 commits into from
Apr 17, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 17, 2024 •
edited by bedevere-app bot
Loading

static_builtin_index_is_set() is only used in asserts; inline it to avoid compiler warnings.

@erlend-aasland
pythongh-94673: Fix compiler warning in typeobject.c
9ad94d3 
static_builtin_index_is_set() is only used in asserts; inline it to avoid compiler warnings.
@bedevere-app bedevere-app bot mentioned this pull request Apr 17, 2024
Closed
ericsnowcurrently
ericsnowcurrently approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. I have one suggestion for handling it a different way, which preserves the intention of the original code.

Objects/typeobject.c Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland enabled auto-merge (squash) April 17, 2024 17:28
@erlend-aasland erlend-aasland merged commit 353ea0b into python:main Apr 17, 2024
34 checks passed
@erlend-aasland erlend-aasland deleted the fix-warning branch April 17, 2024 17:57
@ericsnowcurrently
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalebers kalebers kalebers approved these changes

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @ericsnowcurrently @kalebers