-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-115765: Don't use deprecated AC_EGREP_* macros in configure.ac #115791
Conversation
@mhsmith, would you like to review this? |
@corona10, feel free to take a look at this, if you have the time. |
This comment was marked as outdated.
This comment was marked as outdated.
Found the culprit; typo on my end! ✅ |
Now, there's one more thing we should add before landing this: support configure cache. |
I'm not sure we want to automatically generate the cache variable name in this macro. The first argument would need heavy string modifications to end up as a usable identifier. Perhaps it is best to introduce a new param for the cache variable name. |
Alternatively, all but one usage of PY_CHECK_CPP could be replaced with AX_CHECK_DEFINE, which has caching already built in. |
That's a good suggestion; I'll have a look in a day or two. UPDATE: Created alternative PR gh-116016. |
For the glibc check; do we really need to worry about glibc < 2.1? |
I agree, so #116016 looks like the way to go. |
Superseded by #116016 |
See Autoconf docs: