Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-115765: Don't use deprecated AC_EGREP_* macros in configure.ac #115791

Closed
wants to merge 10 commits into from

Conversation

@erlend-aasland
Copy link
Contributor Author

@mhsmith, would you like to review this?

@erlend-aasland
Copy link
Contributor Author

@corona10, feel free to take a look at this, if you have the time.

configure.ac Outdated Show resolved Hide resolved
configure.ac Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor Author

@mhsmith, thanks for the review; I addressed your remarks in 9c3596d. PTAL.

configure Outdated Show resolved Hide resolved
@erlend-aasland

This comment was marked as outdated.

@erlend-aasland
Copy link
Contributor Author

Found the culprit; typo on my end! ✅

@erlend-aasland
Copy link
Contributor Author

Now, there's one more thing we should add before landing this: support configure cache.

@erlend-aasland
Copy link
Contributor Author

Now, there's one more thing we should add before landing this: support configure cache.

I'm not sure we want to automatically generate the cache variable name in this macro. The first argument would need heavy string modifications to end up as a usable identifier. Perhaps it is best to introduce a new param for the cache variable name.

@mhsmith
Copy link
Member

mhsmith commented Feb 23, 2024

Alternatively, all but one usage of PY_CHECK_CPP could be replaced with AX_CHECK_DEFINE, which has caching already built in.

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Feb 27, 2024

Alternatively, all but one usage of PY_CHECK_CPP could be replaced with AX_CHECK_DEFINE, which has caching already built in.

That's a good suggestion; I'll have a look in a day or two.

UPDATE: Created alternative PR gh-116016.

@erlend-aasland
Copy link
Contributor Author

Alternatively, all but one usage of PY_CHECK_CPP could be replaced with AX_CHECK_DEFINE, which has caching already built in.

For the glibc check; do we really need to worry about glibc < 2.1?

@mhsmith
Copy link
Member

mhsmith commented Feb 28, 2024

I agree, so #116016 looks like the way to go.

@erlend-aasland
Copy link
Contributor Author

Superseded by #116016

@erlend-aasland erlend-aasland deleted the ac/2.72-egrep-source branch February 28, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants