Whoops, cannot use DECREF_INPUTS() in some cases

python · Mar 4, 2023 · 394f2e0 · 394f2e0
1 parent 2b45efe
commit 394f2e0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/Python/bytecodes.c b/Python/bytecodes.c
@@ -1949,7 +1949,7 @@ dummy_func(
             else {
                 err = PyObject_IsTrue(cond);
                 if (err > 0) {
-                    DECREF_INPUTS();
+                    Py_DECREF(cond);
                 }
                 else if (err == 0) {
                     JUMPBY(oparg);
@@ -1978,7 +1978,7 @@ dummy_func(
                     jump = true;
                 }
                 else if (err == 0) {
-                    DECREF_INPUTS();
+                    Py_DECREF(cond);
                 }
                 else {
                     goto error;
@@ -2111,7 +2111,7 @@ dummy_func(
                 }
                 /* iterator ended normally */
                 assert(next_instr[INLINE_CACHE_ENTRIES_FOR_ITER + oparg].op.code == END_FOR);
-                DECREF_INPUTS();
+                Py_DECREF(iter);
                 STACK_SHRINK(1);
                 /* Jump forward oparg, then skip following END_FOR instruction */
                 JUMPBY(INLINE_CACHE_ENTRIES_FOR_ITER + oparg + 1);
@@ -2134,7 +2134,7 @@ dummy_func(
                 it->it_seq = NULL;
                 Py_DECREF(seq);
             }
-            DECREF_INPUTS();
+            Py_DECREF(iter);
             STACK_SHRINK(1);
             /* Jump forward oparg, then skip following END_FOR instruction */
             JUMPBY(INLINE_CACHE_ENTRIES_FOR_ITER + oparg + 1);
@@ -2157,7 +2157,7 @@ dummy_func(
                 it->it_seq = NULL;
                 Py_DECREF(seq);
             }
-            DECREF_INPUTS();
+            Py_DECREF(iter);
             STACK_SHRINK(1);
             /* Jump forward oparg, then skip following END_FOR instruction */
             JUMPBY(INLINE_CACHE_ENTRIES_FOR_ITER + oparg + 1);

diff --git a/Python/generated_cases.c.h b/Python/generated_cases.c.h