-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup json schema validation #10074
base: main
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request improves resource management by loading JSON schemas from package resources instead of relying on file paths. This change is particularly beneficial when Poetry is repackaged. Additionally, it removes unused imports. Sequence diagram for JSON schema validation flowsequenceDiagram
participant Client
participant Validator
participant PackageResources
Client->>Validator: validate_object(obj)
Validator->>PackageResources: Load poetry.json schema
PackageResources-->>Validator: Return schema content
Validator->>PackageResources: Load poetry-schema.json from poetry.core
PackageResources-->>Validator: Return core schema content
Note over Validator: Compile and validate schemas
Validator-->>Client: Return validation errors (if any)
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Secrus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
55fd633
to
a71b9a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Secrus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Pull Request Check List
Resolves: #2965
Some changes towards better resource management, especially for repackaged use of poetry. Twin to python-poetry/poetry-core#819
Summary by Sourcery
Load JSON schemas from package resources.
Enhancements:
Chores: