Stop reading when EPS line becomes too long #6897
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6877
Using the following code to check speed (based on
test_timeout()
),I get
In EpsImagePlugin, after each time
fp.readline()
is run, an error is raised iffp.readline().strip("\r\n")
is longer than 255 characters. So if Pillow isn't going to use the rest of that data, we can stop reading when the line becomes too long.Applying that change, the speed test gives
That's 118 times faster. This should be sufficient to stop intermittent timeouts in our CIs.