-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for soon-EOL Python 3.6 #5768
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
force-pushed
the
rm-3.6
branch
2 times, most recently
from
October 15, 2021 10:44
ca40889
to
5bb7735
Compare
Why |
nulano
reviewed
Oct 15, 2021
I ran |
nulano
reviewed
Oct 15, 2021
hugovk
force-pushed
the
rm-3.6
branch
4 times, most recently
from
October 18, 2021 07:11
d4c7ccd
to
e6531a4
Compare
Merged
Co-authored-by: Ondrej Baranovič <nulano@nulano.eu>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
The Python 3.6 EOL is scheduled for 2021-12-23, before Pillow 9.0.0's 2022-01-02 release
Ran
pyupgrade **/*.py --py36-plus
to upgrade Python syntaxNo changes running
pyupgrade **/*.py --py37-plus
(other than removing stuff that will be removed forPILLOW_VERSION
in another PR)Remove Docker jobs which test on Python 3.6:centos-7-amd64
centos-8-amd64
centos-stream-8-amd64
Perhaps we could upgrade to 3.7 in a CentOSOr check when CentOS Stream 9 is out and what Python it'll haveubuntu-18.04-bionic-amd64
If we want to test 18.04, we can add it addubuntu-18.04
as aninclude:
to the regulartest.yml
Not removed the(Now removed,if sys.version_info >= (3, 7):
stuff around thePILLOW_VERSION
warnings, will remove that in the next PR.PILLOW_VERSION
since removed in #5776.)