Support without distutils #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2146 +/- ##
==========================================
- Coverage 93.64% 93.54% -0.10%
==========================================
Files 88 88
Lines 4358 4371 +13
==========================================
+ Hits 4081 4089 +8
- Misses 277 282 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Bernát Gábor <gaborjbernat@gmail.com>
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
for more information, see https://pre-commit.ci
|
Resolves #1910. |
Signed-off-by: Bernát Gábor <bgabor8@bloomberg.net>
Ark-kun
reviewed
Aug 12, 2021
| @@ -27,7 +27,7 @@ def test_discovery_via_path(monkeypatch, case, tmp_path, caplog, session_app_dat | |||
| elif case == "upper": | |||
| name = name.upper() | |||
| exe_name = "{}{}{}".format(name, current.version_info.major, ".exe" if sys.platform == "win32" else "") | |||
| target = tmp_path / current.distutils_install["scripts"] | |||
| target = tmp_path / current.install_path("scripts") | |||
There was a problem hiding this comment.
Can we test both execution flows paths of install_path?
There was a problem hiding this comment.
What do you mean?
gdubicki
pushed a commit
to gdubicki/virtualenv
that referenced
this pull request
Sep 18, 2021
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bernát Gábor bgabor8@bloomberg.net