Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for object releasing #403

Merged
merged 19 commits into from
Nov 4, 2023
Merged

Add tests for object releasing #403

merged 19 commits into from
Nov 4, 2023

Conversation

almarklein
Copy link
Member

@almarklein almarklein commented Nov 1, 2023

Closes #353

This adds tests, in a new folder so it won't interfere with the unit tests. The idea is basically, doing for each kind of object:

  • Get how many objects we have of each kind.
  • Create a bunch of objects of a specific kind.
  • Make sure the counts are indeed up.
  • Delete the objects.
  • Check that the counts are down.

Todo:

@almarklein almarklein mentioned this pull request Nov 1, 2023
30 tasks
@Korijn
Copy link
Collaborator

Korijn commented Nov 4, 2023

Can you explain what polling the device does conceptually?

@almarklein
Copy link
Member Author

Can you explain what polling the device does conceptually?

From what I understand, wgpu has an an event-loop of sorts, so it can perform asynchronous tasks. Polling the device flushes the device's queue. We also use poll in the functions that are asyn in nature, like buffer mapping. Related to #391.

@almarklein
Copy link
Member Author

I think this is good to go. I'll have a look (probably after the weekend) what the state of #275 is. But in the mean time this is ready for review.

@almarklein
Copy link
Member Author

almarklein commented Nov 4, 2023

@Korijn Korijn merged commit 6ce9ac9 into main Nov 4, 2023
17 checks passed
@Korijn Korijn deleted the mem-test branch November 4, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate memoryleaks Rust panic after creating hundreds of renderers/canvases
2 participants