Guard NPN functions in case they are unavailable #4760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NPN in OpenSSL can be compile-time disabled. In that case, this patch fixes compilation.
|
@reaperhulk can we just drop NPN entirely? I don't think anything should be using it at this point? |
|
@alex we'd need to deprecate and remove it from pyopenssl first (hey we should do that) |
|
Well, if we just set the disabled flag, it'll auto-disable in pyOpenSSL. But yes, we should properly deprecate it, I'll send a PR. |
|
Okay, since we're deprecating on the pyOpenSSL side and it already handles the case where the symbols aren't present let's just go ahead and alter this PR to remove the bindings entirely. |
|
#4765 replaces this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPN in OpenSSL can be compile-time disabled. In that case, this patch
fixes compilation.