Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some ASN1_TIME related functions for the relevant PyOpenSSL patch. #3491

Merged
merged 2 commits into from
Apr 6, 2017

Conversation

moriyoshi
Copy link
Contributor

This patch adds the signatures for the following functions:

  • ASN1_TIME_set_string
  • ASN1_TIME_check

These are necssary in the PyOpenSSL patch which will be submitted shortly.

@mention-bot
Copy link

@moriyoshi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @reaperhulk, @alex and @public to be potential reviewers.

@moriyoshi
Copy link
Contributor Author

The PyOpenSSL patch is here: pyca/pyopenssl#612

@alex
Copy link
Member

alex commented Apr 5, 2017

Jenkins, ok to test.

@alex
Copy link
Member

alex commented Apr 5, 2017

Looks like there are some signature changes in OpenSSL across the versions; you may need to move some of the declerations to the macros section to avoid checking the constness.

@moriyoshi
Copy link
Contributor Author

Yes, totally right. The constness of the argument for ASN1_TIME_check was changed at openssl/openssl@359b0c9. I moved it to MACRO.

@reaperhulk reaperhulk merged commit ef027a6 into pyca:master Apr 6, 2017
@reaperhulk
Copy link
Member

Thanks for your contribution!

@moriyoshi moriyoshi deleted the moriyoshi/add-asn1-time-funcs branch June 21, 2017 13:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants