Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add recently released pypy3.11 #5534

Merged
merged 1 commit into from
Feb 20, 2025
Merged

add recently released pypy3.11 #5534

merged 1 commit into from
Feb 20, 2025

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Feb 18, 2025

Description

PyPy3.11 was released recently. Add it to CI

Suggested changelog entry:

Test PyPy3.11 in CI

@mattip mattip requested a review from henryiii as a code owner February 18, 2025 12:59
@mattip
Copy link
Contributor Author

mattip commented Feb 18, 2025

Note in the weekly binary testing I am seeing a XPASS (an expected XFAIL unexpectedly pass) for test_exceptions::test_cross_module_exception_translator on MacOS + PyPy, is there something different in my setup?

@rwgk
Copy link
Collaborator

rwgk commented Feb 20, 2025

Note in the weekly binary testing I am seeing a XPASS (an expected XFAIL unexpectedly pass) for test_exceptions::test_cross_module_exception_translator on MacOS + PyPy, is there something different in my setup?

Nothing I'm aware of. (Best idea, wild guess, latent UB plus some change in the environment?)

I'll merge this PR, thanks!

What is your opinion about removing PyPy 3.8 testing? (those tests flake quite often)

@rwgk rwgk merged commit 09b9f44 into pybind:master Feb 20, 2025
79 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 20, 2025
@mattip
Copy link
Contributor Author

mattip commented Feb 20, 2025

What is your opinion about removing PyPy 3.8 testing? (those tests flake quite often)

From PyPy's perspective, 3.8 and 3.9 are no longer supported. I don't know if pybind11 still wishes to support out-of-date python versions going forward.

@rwgk
Copy link
Collaborator

rwgk commented Feb 20, 2025

What is your opinion about removing PyPy 3.8 testing? (those tests flake quite often)

From PyPy's perspective, 3.8 and 3.9 are no longer supported. I don't know if pybind11 still wishes to support out-of-date python versions going forward.

I don't. @henryiii?

@henryiii
Copy link
Collaborator

I think those are okay to drop. The biggest issue is that in cibuildwheel, it's all or nothing unless you carefully customize. I'm wondering if we should go back to making the PyPy feature be opt-into out of date versions, rather than than opt into all versions, before cibuildwheel 3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs changelog Possibly needs a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants