-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ghi_clear
to glossary
#2397
base: main
Are you sure you want to change the base?
Conversation
How about a whatsnew entry along the lines of:
Whatsnew entry probably not necessary if this PR is the only glossary change, but I expect we will have further additions and/or modifications in 11.3 so maybe a single entry that lists these together would be helpful? |
A single bullet in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!, minor comment below.
As an idea, you could also put the See :term: ...
in irradiance.dni
and irradiance.dni
, which do use it (but I think it's fine as is, I don't like redirecting users for such an small description).
This should (eventually) happen #2311 so I won't do it here |
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Tests addedUpdates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.