Merge pull request #208 from glennsarti/maint-rubocop

(maint) Fix rubocop violations

.rubocop.yml

@@ -17,6 +17,9 @@ Style/Documentation:
 Metrics/LineLength:
   Enabled: false
 
+# Empty method definitions over more than one line is ok
+Style/EmptyMethod:
+  Enabled: false
 
 # Due to legacy codebase
 #   - Globals are used liberally
@@ -29,6 +32,8 @@ Metrics/PerceivedComplexity:
   Enabled: false
 Metrics/CyclomaticComplexity:
   Enabled: false
+Metrics/BlockNesting:
+  Enabled: false
 #   - Long Methods, Classes, Blocks, and Modules
 Metrics/MethodLength:
   Enabled: false
@@ -39,6 +44,9 @@ Metrics/BlockLength:
 Metrics/ModuleLength:
   Enabled: false
 
+# WordArray is crashing rubocop in lib/vmpooler/api/helpers.rb
+Style/WordArray:
+  Enabled: false
 
 # Either sytnax for regex is ok
 Style/RegexpLiteral:

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-03-02 20:16:29 -0800 using RuboCop version 0.47.1.
+# on 2017-03-16 15:37:18 -0700 using RuboCop version 0.47.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -13,10 +13,9 @@ Lint/AssignmentInCondition:
     - 'lib/vmpooler/api/helpers.rb'
     - 'lib/vmpooler/api/v1.rb'
 
-# Offense count: 6
+# Offense count: 5
 Lint/ConditionPosition:
   Exclude:
-    - 'lib/vmpooler/api/dashboard.rb'
     - 'lib/vmpooler/pool_manager.rb'
 
 # Offense count: 3
@@ -30,13 +29,12 @@ Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'lib/vmpooler/api/helpers.rb'
 
-# Offense count: 8
+# Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
 Lint/UnusedMethodArgument:
   Exclude:
     - 'lib/vmpooler/api/helpers.rb'
-    - 'lib/vmpooler/dummy_statsd.rb'
     - 'lib/vmpooler/pool_manager.rb'
     - 'lib/vmpooler/vsphere_helper.rb'
 
@@ -46,11 +44,6 @@ Lint/UselessAssignment:
     - 'lib/vmpooler/api/dashboard.rb'
     - 'lib/vmpooler/api/helpers.rb'
 
-# Offense count: 5
-# Configuration parameters: CountBlocks.
-Metrics/BlockNesting:
-  Max: 5
-
 # Offense count: 1
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
@@ -134,13 +127,12 @@ Style/EmptyLines:
   Exclude:
     - 'lib/vmpooler/api/dashboard.rb'
 
-# Offense count: 2
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
 Style/EmptyLinesAroundClassBody:
   Exclude:
-    - 'lib/vmpooler/api/dashboard.rb'
     - 'lib/vmpooler/api/helpers.rb'
 
 # Offense count: 3
@@ -151,27 +143,12 @@ Style/EmptyLinesAroundModuleBody:
   Exclude:
     - 'lib/vmpooler/api/helpers.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/EmptyLiteral:
-  Exclude:
-    - 'lib/vmpooler/api/dashboard.rb'
-
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-# SupportedStyles: compact, expanded
-Style/EmptyMethod:
-  Exclude:
-    - 'lib/vmpooler/dummy_statsd.rb'
-
-# Offense count: 3
-# Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
 Style/ExtraSpacing:
   Exclude:
     - 'lib/vmpooler/pool_manager.rb'
-    - 'lib/vmpooler/statsd.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
@@ -244,13 +221,11 @@ Style/IndentHash:
     - 'lib/vmpooler/api/helpers.rb'
     - 'lib/vmpooler/api/v1.rb'
 
-# Offense count: 4
+# Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: Width.
 Style/IndentationWidth:
   Exclude:
-    - 'lib/vmpooler/api/dashboard.rb'
-    - 'lib/vmpooler/api/reroute.rb'
     - 'lib/vmpooler/api/v1.rb'
     - 'lib/vmpooler/vsphere_helper.rb'
 
@@ -412,13 +387,12 @@ Style/SpaceAroundKeyword:
   Exclude:
     - 'lib/vmpooler/api/v1.rb'
 
-# Offense count: 4
+# Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: AllowForAlignment.
 Style/SpaceAroundOperators:
   Exclude:
     - 'lib/vmpooler/api/v1.rb'
-    - 'lib/vmpooler/statsd.rb'
 
 # Offense count: 4
 # Cop supports --auto-correct.
@@ -442,25 +416,14 @@ Style/SpaceInsideParens:
   Exclude:
     - 'lib/vmpooler/api/v1.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/SpaceInsidePercentLiteralDelimiters:
-  Exclude:
-    - 'lib/vmpooler/api.rb'
-
-# Offense count: 47
+# Offense count: 12
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Exclude:
-    - 'lib/vmpooler/api.rb'
-    - 'lib/vmpooler/api/dashboard.rb'
-    - 'lib/vmpooler/api/reroute.rb'
     - 'lib/vmpooler/api/v1.rb'
-    - 'lib/vmpooler/graphite.rb'
     - 'lib/vmpooler/pool_manager.rb'
-    - 'lib/vmpooler/statsd.rb'
     - 'lib/vmpooler/vsphere_helper.rb'
     - 'vmpooler'
 

lib/vmpooler/api.rb

@@ -22,15 +22,15 @@ def initialize
 
     # Load dashboard components
     begin
-      require "dashboard"
+      require 'dashboard'
     rescue LoadError
       require File.expand_path(File.join(File.dirname(__FILE__), 'dashboard'))
     end
 
     use Vmpooler::Dashboard
 
     # Load API components
-    %w( helpers dashboard reroute v1 ).each do |lib|
+    %w(helpers dashboard reroute v1).each do |lib|
       begin
         require "api/#{lib}"
       rescue LoadError