-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(CAT-2193): Fixed kubernetes environment setup for Debian. #694
(CAT-2193): Fixed kubernetes environment setup for Debian. #694
Conversation
77b9182
to
f2d1480
Compare
f2d1480
to
cc118b7
Compare
puppetlabs/provision#281 required to be merged before merging this. |
Can you extract the version to a parameter. Also why set the default to v1.28 latests is v1.32 |
f2a4a65
to
b05b1f2
Compare
Updated the default values to use latest |
manifests/repos.pp
Outdated
@@ -60,16 +60,18 @@ | |||
|
|||
) { | |||
if $create_repos { | |||
$kubernetes_core_version = 'v1.32' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move this to params instead of hardcoded string? Maybe call it minor_version
(according to semantic versioning)?
It might be derived from kubernetes::version
$minor_version = $kubernetes::version.split('\.')[0, 2].join('.')
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Kubernetes version is intended for core packages, which is why I've named it accordingly. Additionally, I've created a new params.pp
file to consolidate all the default values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't make sense to use kubernetes::version = 1.28.10
and k8s_core_package_version = 1.32
, right?. It doesn't make sense to me to define the same information on two places.
params.pp
are considered anti-pattern, could you please move it to data/common.yaml
resp. data/os/RedHat.yaml
etc.?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused between kubernetes::version
and k8s_core_package_version
. Thank you for clarifying and helping me make sense of it. I've updated the code accordingly.
b05b1f2
to
8279434
Compare
8279434
to
d140975
Compare
…s spec tests to run successfully for debian platform
d140975
to
0cc4f36
Compare
Summary
Fixed kubernetes environment setup for Debian. This allows spec tests to run successfully for debian platform
Checklist
puppet apply
)