Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update devcontainer format + Ruby vscode extension #666

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Update devcontainer format + Ruby vscode extension #666

merged 1 commit into from
Jan 15, 2024

Conversation

jorhett
Copy link
Contributor

@jorhett jorhett commented Dec 9, 2023

Summary

  • The devcontainer spec changed to put vscode-specific settings under customizations.vscode
  • The rebornix Ruby extension was deprecated, with a recommendation to use the Ruby LSP extension instead
  • Replace tabs in JSON with spaces

Related Issues (if any)

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • [X ] Manually verified. (For example puppet apply)

@jorhett jorhett requested review from bastelfreak, deric and a team as code owners December 9, 2023 19:43
@deric deric force-pushed the jrhett/update-devcontainer-format branch from 66ba63a to be02fed Compare January 10, 2024 11:13
@jorhett
Copy link
Contributor Author

jorhett commented Jan 14, 2024

@deric any chance of getting a new release out with this and #639 in it? This is a long-standing blocker

@deric deric merged commit 6f63cc2 into puppetlabs:main Jan 15, 2024
5 of 7 checks passed
@deric
Copy link
Collaborator

deric commented Jan 15, 2024

@jorhett Yeah, that would be nice, but I'm unable to do a release without other code reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deric deric deric approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorhett @deric @ia-content