Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Fix missing stubs in docker_spec.rb #589

Merged
merged 1 commit into from
Mar 18, 2020
Merged

(maint) Fix missing stubs in docker_spec.rb #589

merged 1 commit into from
Mar 18, 2020

Conversation

Filipovici-Andrei
Copy link

Fixed docker version fact, so that it's compatible with Facter 4.
Changed module which executes commands.

@codecov-io
Copy link

codecov-io commented Mar 18, 2020

Codecov Report

Merging #589 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #589   +/-   ##
=======================================
  Coverage   28.02%   28.02%           
=======================================
  Files          19       19           
  Lines         685      685           
=======================================
  Hits          192      192           
  Misses        493      493           
Impacted Files Coverage Δ
lib/facter/docker.rb 80.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144c484...8fbb0b5. Read the comment docs.

Copy link
Contributor

@carabasdaniel carabasdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carabasdaniel carabasdaniel merged commit 2c7d7c2 into puppetlabs:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants