Expose notify_update to apt::conf #551
Conversation
|
Pins indeed don't need to trigger an |
|
Hi @daenney, is there anything else I need to do to get this merged? |
|
Oh, yes, sorry. It's currently lacking tests for the behaviour you've changed so though the original examples still work we're not validating the new possible uses. We also need the documentation around the defined types updated with the new parameter and how it can be used. |
|
Hi @daenney, I've added documentation and rspec test for apt::conf, I hope its sufficient - this is my first attempt at rspec-puppet tests. |
|
Hi @daenney is there anything else necessary to get this merged? |
bdellegrazie
force-pushed
the
MODULES-2269
branch
from
fa6e630 to
67777b6
Compare
|
Yes, I would really appreciate a squash here. It's a single feature and as such I'd like to merge it as a single commit into history. |
* Expose the underlying notify_update setting of the apt::settings resource This is because not all configuration file changes should trigger an apt::update notification * apt::pin also shouldn't result in an apt-update call Adding a pin configuration should apply to the next apt-get update call it shouldn't trigger one itself. * Added documentation * Add tests for apt::conf notify_update
bdellegrazie
force-pushed
the
MODULES-2269
branch
from
67777b6 to
9ad4fd6
Compare
|
Hi @daenney squashed as requested, rebased to current master as well. |
|
@mhaskel Good to go? |
Expose notify_update to apt::conf
|
@bdellegrazie thanks for the contribution! |
Created ticket: https://tickets.puppetlabs.com/browse/MODULES-2269
This pull request simply exposes notify_update parameter of underlying apt::setting defined type to the apt::conf defined type as it isn't always appropriate to trigger an update for a specific configuration file.
I don't believe apt::pin shouldn't trigger an update either (set notify_update to false) - however willing to rework this if people disagree and simply expose notify_update as for apt::conf.
Happy to discuss further.
Thanks