Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #2531 from buzzdeee/master" #2641

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Revert "Merge pull request #2531 from buzzdeee/master" #2641

merged 1 commit into from
Nov 18, 2023

Conversation

joshcooper
Copy link
Contributor

This reverts commit e6cee0a, reversing changes made to f065e53.

Commit 3bda38c introduced order dependent spec failures which can be reproduced:

rspec -fd './spec/facter/resolvers/openbsd/virtual_spec.rb[1:2:1]' './spec/facter/util/facts/posix/virtual_detector_spec.rb[1:1:12:1]' --order random:17181

@joshcooper
Revert "Merge pull request puppetlabs#2531 from buzzdeee/master"
cce8166 
This reverts commit e6cee0a, reversing
changes made to f065e53.
@joshcooper joshcooper requested a review from a team as a code owner November 18, 2023 00:42
@joshcooper joshcooper merged commit 9fc23c5 into puppetlabs:main Nov 18, 2023
18 checks passed
@joshcooper joshcooper deleted the order_dependent_17181 branch November 18, 2023 00:47
@joshcooper joshcooper added maintenance Maintenance chores are excluded from changelogs enhancement New feature or enhancement and removed maintenance Maintenance chores are excluded from changelogs labels Nov 29, 2023
@joshcooper joshcooper added maintenance Maintenance chores are excluded from changelogs and removed enhancement New feature or enhancement labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@joshcooper