Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(FACT-3436) Revert Debian ARM architecture change #2636

Merged
merged 2 commits into from
Nov 10, 2023
Merged

(FACT-3436) Revert Debian ARM architecture change #2636

merged 2 commits into from
Nov 10, 2023

Conversation

mhashizume
Copy link
Contributor

The os.architecture fact has historically resolved differently for Debian for x86 and x86_64 to use Debian's architecture convention, i.e. using i386 and amd64, respectively.

We attempted to continue that convention for AARCH/ARM prior to official Puppet support for Debian on ARM in #2621. However, Debian-based Ubuntu on ARM has been officially supported by Puppet since 2021 and this change to os.architecture has the potential to break existing code.

This change reverts changes made in #2621 and #2627 to return Facter to its prior behavior of the os.architecture fact resolving to aarch64 on Debian.

@mhashizume
Revert "(FACT-3436) Standardize Debian architecture fact"
749f4a3 
This reverts commit bc5a529.

This change caused too many breaking changes with platforms already
supported by Puppet; namely, Ubuntu on ARM.
@mhashizume
Revert "(FACT-3442) Update os.architecture fact for debian and ubuntu…
7e34fe2 
… to arm64"

This reverts commit dc1837a.
@mhashizume mhashizume requested a review from a team as a code owner November 10, 2023 19:16
@joshcooper joshcooper merged commit 44c49f6 into puppetlabs:main Nov 10, 2023
18 checks passed
@mhashizume mhashizume deleted the FACT-3436/main/revert-debian-architecture branch November 10, 2023 21:48
@joshcooper joshcooper added the maintenance Maintenance chores are excluded from changelogs label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcooper joshcooper joshcooper approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhashizume @joshcooper