feat(entra): add new check entra_password_hash_sync_enabled
#7061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7061 +/- ##
==========================================
- Coverage 88.76% 88.74% -0.02%
==========================================
Files 1201 1202 +1
Lines 34920 34959 +39
==========================================
+ Hits 30996 31024 +28
- Misses 3924 3935 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
andoniaf
reviewed
Feb 27, 2025
| facilitating seamless authentication and enhancing leaked credential protection. Without password hash | ||
| synchronization, users might have to manage multiple passwords and detection of leaked credentials would be compromised. | ||
|
|
||
| Note: This control applies only to hybrid deployments using Microsoft Entra Connect sync and does not apply to federated domains. |
There was a problem hiding this comment.
Should we check then if the domain is federated to avoid false positives?
There was a problem hiding this comment.
But you can have multiple domains... 🤔 Not sure how this setting would behave in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR introduces a new check for M365 service: Entra. This new check verifies if Password hash synchronization is enabled. This is one of the sign-in methods used to accomplish hybrid identity synchronization.
The only way to have this enabled is using Microsoft Entra Connect, an application from Microsoft that synchronizes a hash of a user's password from an on-premises Active Directory instance to a cloud-based Entra ID instance in order to have hybrid environment safer.
Description
Added new check
entra_password_hash_sync_enabledwith its unit tests and modifed the service to add_get_organizationapi callChecklist
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.