-
Notifications
You must be signed in to change notification settings - Fork 711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate perflib #1241
Integrate perflib #1241
Conversation
6bb4d89
to
321d053
Compare
Implementations since from point of view, we may need some additional tests. |
I run some test on Windows Server, I go no issues with default settings. |
Looking at the commits the feature branch could do with a rebase (we're currently proposing to merge a merge commit); I have no objections to the change itself, it's looking good. Once rebased, are you happy for me to merge this? |
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
Let me take an other test, in case I do the rebase incorrectly. |
Are you interested in taking over perflib library maintenance? I no longer operate any Windows server and I'd be more than happy to archive the repo and point users here instead. |
@leoluk this PR contains only a subset of perflib_exporter. Only the functions and vars that windows_exporter requires are part of this PR I guess to maintain the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jkroepke are you happy for this to be merged? I have no further concerns or queries for this change.
I'm happy, yes |
Integrate perflib
Fixes #1240
What I do here:
/perflib
/perflib/consts.go
HelpName
lookups, sincewindows_exporter
do not use themQueryNameTable
to reduce startup times.QueryNameTable
initialization.