feat: Add mysqld_exporter role #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardar
requested changes
Mar 5, 2023
There was a problem hiding this comment.
Also needs:
- Argument specs for the role (
meta/argument_specs.yml. - Integration tests to be able to run molecule with ansible-test.
Basically just create
tests/integration/targets/molecule-<role name>-<molecule scenario>/runme.sh
such as:
tests/integration/targets/molecule-mysqld_exporter-default/runme.sh
And have the following in the runme script:
#!/usr/bin/env bash
collection_root=$(pwd | grep -oP ".+\/ansible_collections\/\w+?\/\w+")
source "$collection_root/tests/integration/molecule.sh"
|
Yup, I just copied the node_exporter and am still working on this. |
SuperQ
force-pushed
the
superq/mysqld_exporter
branch
from
99f04e0 to
d360b26
Compare
SuperQ
force-pushed
the
superq/mysqld_exporter
branch
from
d360b26 to
a36ac10
Compare
github-actions
bot
added
enhancement
SuperQ
force-pushed
the
superq/mysqld_exporter
branch
from
a36ac10 to
1286c7e
Compare
github-actions
bot
added
enhancement
SuperQ
force-pushed
the
superq/mysqld_exporter
branch
from
1286c7e to
29f4228
Compare
github-actions
bot
added
enhancement
SuperQ
force-pushed
the
superq/mysqld_exporter
branch
from
29f4228 to
993d9f8
Compare
github-actions
bot
added
enhancement
SuperQ
force-pushed
the
superq/mysqld_exporter
branch
from
993d9f8 to
dab41e8
Compare
github-actions
bot
added
enhancement
gardar
requested changes
Mar 10, 2023
SuperQ
force-pushed
the
superq/mysqld_exporter
branch
from
dab41e8 to
871b6fe
Compare
github-actions
bot
added
enhancement
SuperQ
force-pushed
the
superq/mysqld_exporter
branch
from
871b6fe to
9a44d1b
Compare
github-actions
bot
added
enhancement
SuperQ
force-pushed
the
superq/mysqld_exporter
branch
from
9a44d1b to
f8e655e
Compare
github-actions
bot
added
enhancement
|
Ok, I updated based on #65 |
gardar
requested changes
Mar 13, 2023
Add a role for deploying the mysqld_exporter. Signed-off-by: SuperQ <superq@gmail.com>
SuperQ
force-pushed
the
superq/mysqld_exporter
branch
from
f8e655e to
af8fc8f
Compare
github-actions
bot
added
enhancement
gardar
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a role for deploying the mysqld_exporter.