bugfix: properly handle timeouts during OpenSSL cipher enumeration #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackerbuddy
changed the title
hackerbuddy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Running
./tlsx -u IP_WITH_WAF_PROTECTION -ve -cert -json -sm openssl -ceagainst some hosts with WAF protection will cause thetlsxprogram to never complete.Explanation
Timeouts have not been implemented for OpenSSL cipher enumeration in the
tlsxscanning tool in theexecOpenSSL()function. Due to this issue, if partway through scanning, theopensslbinary becomes unresponsive for any reason (e.g. WAF causes scanned IP address to stop responding toopensslhalfway through scanning), thetlsxprogram will also become unresponsive, and may not finish.Fix
Simply use the Timeout designated in flags.