Fix split hostnet example not creating #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecheney
approved these changes
Mar 14, 2019
| @@ -36,9 +36,9 @@ spec: | |||
| - --xds-port | |||
| - $(CONTOUR_SERVICE_PORT) | |||
| - --envoy-service-http-port | |||
There was a problem hiding this comment.
Can you please make match troubleshooting.md and the help text generated by contour serve -h
- --envoy-service-http-port=80
- --envoy-service-https-port=443
Then we shouldn't have to deal with wacky yaml quoting rules
There was a problem hiding this comment.
Great point @dfc! I updated the other args to match so we don't have different examples.
Signed-off-by: Steve Sloka <slokas@vmware.com>
stevesloka
force-pushed
the
fixSplitDeployment
branch
from
c2b7a82 to
7157056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example hostnet-split example didn't have escaped strings for the host-ports causing an error when applying the manifest.
Fixes #940
Signed-off-by: Steve Sloka slokas@vmware.com