Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to golang 1.24.0 and golangci-lint v1.64.5 #6918

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

tsaarni
Copy link
Member

@tsaarni tsaarni commented Feb 26, 2025

This change updates to Go 1.24.0. See https://go.dev/doc/devel/release#go1.24.0 for details.

The PR also updates golangci-lint to v1.64.5 for Go 1.24 support and fixes lint errors reported by new linter version

apis/projectcontour/v1alpha1/contourconfig_helpers.go:148:34: redefines-builtin-id: redefinition of the built-in function min (revive)
func ValidateTLSProtocolVersions(min, max string) error {
                                 ^
test/e2e/provisioner.go:111:38: redefines-builtin-id: redefinition of the built-in function new (revive)
func (p *Provisioner) ensureResource(new, existing client.Object) error {
                                     ^
test/e2e/deployment.go:269:37: redefines-builtin-id: redefinition of the built-in function new (revive)
func (d *Deployment) ensureResource(new, existing client.Object) error {

@tsaarni tsaarni added the release-note/small A small change that needs one line of explanation in the release notes. label Feb 26, 2025
@tsaarni tsaarni requested a review from a team as a code owner February 26, 2025 07:09
@tsaarni tsaarni requested review from skriss and sunjayBhatia and removed request for a team February 26, 2025 07:09
@sunjayBhatia sunjayBhatia requested review from a team, wilsonwu and izturn and removed request for a team February 26, 2025 07:09
Signed-off-by: Tero Saarni <tero.saarni@est.tech>
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.70%. Comparing base (7bd93a1) to head (98b0d9c).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6918   +/-   ##
=======================================
  Coverage   80.70%   80.70%           
=======================================
  Files         131      131           
  Lines       19816    19816           
=======================================
  Hits        15993    15993           
  Misses       3533     3533           
  Partials      290      290           

Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @tsaarni!

@skriss skriss merged commit 0091480 into projectcontour:main Feb 26, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/small A small change that needs one line of explanation in the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants