Blocking replicated resources write operations put in place by tenant owners #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for capsule-documentation canceled.
|
|
@prometherion that's looks good. Just suggest to use the same strategy for all types of tenant resources, i.e. blocking vs reconciliating. Do we have different ways to handle tenant resources in the current implementation? |
prometherion
force-pushed
the
issues/732
branch
from
65bbc33 to
13dcdf7
Compare
We can discuss it in a new issue/discussion for the upcoming release, but definitely it would be interesting, although breaking from the API perspective because, if I understood correctly, it means moving the NetworkPolicy and LimitRange definitions from the Tenant API to the GlobalTenantResource. |
prometherion
commented
Mar 24, 2023
prometherion
force-pushed
the
issues/732
branch
from
13dcdf7 to
234aab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #732.
@MaxFedotov @oliverbaehler @bsctl WDYT of this? Essentially, replicated resources managed through a
GlobalTenantResourceor aTenantResourcecannot be deleted or edited by Tenant Owners. This leads to avoiding an inconsistent state of the replicated resources.Keep in mind that resources can be deleted by admin users or k8s controller managers.